Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update the focus outline in the menu item component #29753

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jan 16, 2025

Description

This PR updates the outline style when the user navigates menu items using the TAB key. This ensures the user can clearly identify which item is currently focused.

Open in GitHub Codespaces

Related issues

#26728

Manual testing steps

  1. Open the menu
  2. Navigate through the items using the TAB key
  3. Verify that the outline is displayed correctly on the focused item

Screenshots/Recordings

Before

After

https://www.loom.com/share/25a3748a1a8b49e6b3cf617ccf791240?sid=cbe7a8d6-46d9-431a-a0dd-682c6cf209a2

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati self-assigned this Jan 16, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications Notifications team label Jan 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7fdc4f0]
Page Load Metrics (1715 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28519841566422203
domContentLoaded14572035169014369
load15122046171514067
domInteractive26141563215
backgroundConnect585282211
firstReactRender16101533115
getState495142110
initialActions01000
loadScripts10401591125512962
setupStore676172210
uiStartup167624872058239115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -3 Bytes (-0.00%)
  • ui: -1 Bytes (-0.00%)
  • common: -1 Bytes (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants