fix: remove check for changeX token from test

[sahar-fehri]

Description

PR to temporarily fix flakey test in CI.

The error suggests that its looking for token "Changex" in the UI; while looking at the screenshot from CI the token imported is "changeX";
So the check in the test should be more like
await tokenList.check_tokenIsDisplayed('ChangeX');
and not
await tokenList.check_tokenIsDisplayed('Changex');
In this PR i have removed the check from the test to unblock CI.

Related issues

Fixes:

Related: #29750

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [62079e0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (2123 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	296	2700	1849	651	313
		domContentLoaded	1852	2657	2089	177	85
		load	1881	2679	2123	173	83
		domInteractive	31	124	58	25	12
		backgroundConnect	6	79	22	19	9
		firstReactRender	22	106	53	33	16
		getState	8	105	42	28	13
		initialActions	0	1	0	0	0
		loadScripts	1384	1988	1555	142	68
		setupStore	7	92	28	29	14
		uiStartup	2236	3197	2557	259	124

Bundle size diffs [🚀 Bundle size reduced!]

• background: -3 Bytes (-0.00%)
• ui: -1 Bytes (-0.00%)
• common: -1 Bytes (-0.00%)

[sahar-fehri]

The list we get from the api has this token

  {
    "address": "0x7051faed0775f664a0286af4f75ef5ed74e02754",
    "symbol": "CHANGE",
    "decimals": 18,
    "name": "Changex",
    "iconUrl": "https://assets.coingecko.com/coins/images/26487/thumb/Changex-mark-200x200.png?1696525560",
    "type": "erc20",
    "aggregators": [
      "coinGecko",
      "oneInch",
      "socket",
      "sonarwatch",
      "coinmarketcap",
      "rango"
    ],
    "occurrences": 6
  },

Which as you can see has the name changex instead of changeX.
Changex is the name i see when run the test locally; wondering if the API used to return changeX at some point and this a cache issue?

[gambinish]

LGTM, but maybe we should comment out the line of code rather than remove. Just as a reminder for later.

[metamaskbot]

Builds ready [42fcfa0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1628 ± 49 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1504	1909	1629	105	51
		domContentLoaded	1488	1899	1611	108	52
		load	1507	1904	1628	103	49
		domInteractive	26	165	50	31	15
		backgroundConnect	7	67	18	16	8
		firstReactRender	15	76	42	24	11
		getState	5	45	8	8	4
		initialActions	0	1	0	0	0
		loadScripts	1072	1493	1191	102	49
		setupStore	5	65	12	16	8
		uiStartup	1673	2079	1838	110	53

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [5fb877c]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1772 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1470	2164	1778	168	80
		domContentLoaded	1459	2094	1749	158	76
		load	1481	2168	1772	167	80
		domInteractive	26	68	39	13	6
		backgroundConnect	6	71	20	18	9
		firstReactRender	17	104	57	35	17
		getState	5	80	17	21	10
		initialActions	0	1	0	0	0
		loadScripts	1009	1668	1303	147	71
		setupStore	6	78	32	27	13
		uiStartup	1728	2630	2210	241	116

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)