fix: update eth-ledger-keyring-bridge lib to fix web pack issue. #29722

dawnseeker8 · 2025-01-15T10:28:12Z

This PR will update the ledger keyring bridge library again to solve the webpack build issue.

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-15T10:28:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-01-15T10:29:28Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

dawnseeker8 · 2025-01-15T10:36:43Z

@metamaskbot update-policies

metamaskbot · 2025-01-15T10:47:22Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-15T11:24:34Z

Builds ready [aa7b152]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1672 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	266	1883	1598	321	154
		domContentLoaded	1491	1876	1645	108	52
		load	1511	1883	1672	103	50
		domInteractive	25	186	53	44	21
		backgroundConnect	5	65	27	19	9
		firstReactRender	16	97	40	29	14
		getState	4	78	15	20	10
		initialActions	0	1	0	0	0
		loadScripts	1101	1408	1221	88	42
		setupStore	6	86	20	25	12
		uiStartup	1668	2473	2006	210	101

Bundle size diffs [🚀 Bundle size reduced!]

background: -12.28 KiB (-0.21%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…ridge library.

dawnseeker8 · 2025-01-15T15:32:54Z

@SocketSecurity ignore npm/[email protected]

@SocketSecurity ignore npm/[email protected]

# Conflicts: # package.json # yarn.lock

… files.

socket-security · 2025-01-15T15:41:03Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	316 kB	metamaskbot

View full report↗︎

… files.

dawnseeker8 · 2025-01-15T15:55:05Z

@metamaskbot update-policies

dawnseeker8 · 2025-01-15T16:01:50Z

@metamaskbot update-policies

metamaskbot · 2025-01-15T16:08:03Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-15T16:14:31Z

No policy changes

Gudahtt

LGTM!

metamaskbot · 2025-01-15T16:44:51Z

Builds ready [af22850]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1839 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	429	2130	1754	356	171
		domContentLoaded	1523	2349	1820	216	104
		load	1532	2356	1839	213	102
		domInteractive	25	293	65	60	29
		backgroundConnect	6	53	20	12	6
		firstReactRender	17	98	38	27	13
		getState	5	81	22	24	12
		initialActions	0	1	0	0	0
		loadScripts	1112	1921	1371	198	95
		setupStore	6	56	17	18	9
		uiStartup	1765	2852	2116	288	138

Bundle size diffs [🚀 Bundle size reduced!]

background: -12.28 KiB (-0.21%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

itsyoboieltr

LGTM!

fix: use preview build of library to do the testing.

9cca3e9

metamaskbot added the team-hardware-wallets label Jan 15, 2025

dawnseeker8 and others added 2 commits January 15, 2025 18:43

fix: policy update

43fbe54

Update LavaMoat policies

aa7b152

fix: update package.json to use latest @metamask/eth-ledger-keyring-b…

326cd27

…ridge library.

dawnseeker8 added 2 commits January 15, 2025 23:36

Merge branch 'main' into fix/ledger-keyring-library-upgrade-for-webpack

7b339d5

# Conflicts: # package.json # yarn.lock

fix: fix the conflict during rebase from main. also update the policy…

5069673

… files.

dawnseeker8 marked this pull request as ready for review January 15, 2025 15:40

dawnseeker8 requested review from a team as code owners January 15, 2025 15:40

fix: fix the conflict during rebase from main. also update the policy…

61c8876

… files.

fix: revert policy files back to main branch version.

b74f6f3

dawnseeker8 and others added 2 commits January 16, 2025 00:02

Merge branch 'main' into fix/ledger-keyring-library-upgrade-for-webpack

44892fe

Update LavaMoat policies

af22850

Gudahtt approved these changes Jan 15, 2025

View reviewed changes

itsyoboieltr approved these changes Jan 15, 2025

View reviewed changes

itsyoboieltr added this pull request to the merge queue Jan 15, 2025

DDDDDanica approved these changes Jan 15, 2025

View reviewed changes

pedronfigueiredo approved these changes Jan 15, 2025

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025

Gudahtt added this pull request to the merge queue Jan 15, 2025

Merged via the queue into main with commit e82092e Jan 15, 2025
72 checks passed

Gudahtt deleted the fix/ledger-keyring-library-upgrade-for-webpack branch January 15, 2025 18:52

github-actions bot locked and limited conversation to collaborators Jan 15, 2025

metamaskbot added the release-12.11.1 Issue or pull request that will be included in release 12.11.1 label Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update eth-ledger-keyring-bridge lib to fix web pack issue. #29722

fix: update eth-ledger-keyring-bridge lib to fix web pack issue. #29722

dawnseeker8 commented Jan 15, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Jan 15, 2025

socket-security bot commented Jan 15, 2025 •

edited

Loading

dawnseeker8 commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

dawnseeker8 commented Jan 15, 2025

socket-security bot commented Jan 15, 2025 •

edited

Loading

dawnseeker8 commented Jan 15, 2025

dawnseeker8 commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

Gudahtt left a comment

metamaskbot commented Jan 15, 2025

itsyoboieltr left a comment

fix: update eth-ledger-keyring-bridge lib to fix web pack issue. #29722

fix: update eth-ledger-keyring-bridge lib to fix web pack issue. #29722

Conversation

dawnseeker8 commented Jan 15, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 15, 2025

socket-security bot commented Jan 15, 2025 • edited Loading

dawnseeker8 commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

dawnseeker8 commented Jan 15, 2025

socket-security bot commented Jan 15, 2025 • edited Loading

dawnseeker8 commented Jan 15, 2025

dawnseeker8 commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 15, 2025

itsyoboieltr left a comment

Choose a reason for hiding this comment

dawnseeker8 commented Jan 15, 2025 •

edited by github-actions bot

Loading

socket-security bot commented Jan 15, 2025 •

edited

Loading

socket-security bot commented Jan 15, 2025 •

edited

Loading