Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove segmented tab on confirm import modal #29720

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jan 15, 2025

Description

This PR removes the segmented tab on the confirm import token modal as described in this issue: #26788

Open in GitHub Codespaces

Related issues

#26788

Manual testing steps

  1. Start the procedure to import a token
  2. Confirm the token to be imported
  3. On the confirmation page, the tab should no longer be visible

Screenshots/Recordings

Before

After

https://www.loom.com/share/b3a522ccf9974c06a73ea6236db89cc6?sid=b56a3ed9-6a06-4a23-8ed1-eecc1fa73d8a

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati self-assigned this Jan 15, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications Notifications team label Jan 15, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [9689292]
Page Load Metrics (1871 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33222471790418201
domContentLoaded148822381840249120
load154122511871246118
domInteractive166533115
backgroundConnect776302411
firstReactRender1579372311
getState56116147
initialActions01000
loadScripts11181749137520297
setupStore76318188
uiStartup175625532154268129
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [6087f49]
Page Load Metrics (1659 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45517861593274131
domContentLoaded1473176316408340
load1478179616598541
domInteractive268539157
backgroundConnect66917157
firstReactRender1592362512
getState470162010
initialActions01000
loadScripts1049133712197837
setupStore66314168
uiStartup17202433195819393
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants