Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 284.0.0 #5169

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Release 284.0.0 #5169

merged 2 commits into from
Jan 17, 2025

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jan 17, 2025

Explanation

New RC for the 284.0.0

References

Changelog

@metamask/[email protected]

Changed

  • BREAKING: Base class of DecryptMessageManager and EncryptionPublicKeyManager(AbstractMessageManager) now expects new options to initialise (#5103)
  • Bump @metamask/base-controller from ^7.0.0 to ^7.1.0 (#5079)

Removed

  • BREAKING: Removed internal event emitter (hub property) from AbstractMessageManager (#5103)
  • BREAKING: unapprovedMessage and updateBadge removed from internal events. These events are now emitted from messaging system (#5103)
    • Controllers should now listen to DerivedManagerName:X event instead of using internal event emitter.

@metamask/[email protected]

Changed

  • Bump @metamask/eth-snap-keyring from ^8.0.0 to ^8.1.0 (#5167)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@OGPoyraz OGPoyraz requested review from a team as code owners January 17, 2025 07:47
vinistevam
vinistevam previously approved these changes Jan 17, 2025
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owned files LGTM!

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OGPoyraz OGPoyraz merged commit 52d1c16 into main Jan 17, 2025
120 checks passed
@OGPoyraz OGPoyraz deleted the release/284.0.0 branch January 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants