-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multichain assets controller #5138
base: main
Are you sure you want to change the base?
Conversation
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
symbol: 'SOL', | ||
native: true, | ||
fungible: true, | ||
iconBase64: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be an url? We are getting the url from the static api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too, it was defined as iconBase64
in this document which i think is different than a url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this is better to use a base64 here, in case the logo we want to use is not hosted "anywhere".
Also, using "untrusted URLs" seems always """risky""" (I don't have good example for now) 🙈
Explanation
References
Changelog
@metamask/package-a
@metamask/package-b
Checklist