Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multichain assets controller #5138

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sahar-fehri
Copy link
Contributor

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "20.0.2-preview-62a75dc",
  "@metamask-previews/address-book-controller": "6.0.2-preview-62a75dc",
  "@metamask-previews/announcement-controller": "7.0.2-preview-62a75dc",
  "@metamask-previews/approval-controller": "7.1.2-preview-62a75dc",
  "@metamask-previews/assets-controllers": "45.1.2-preview-62a75dc",
  "@metamask-previews/base-controller": "7.1.1-preview-62a75dc",
  "@metamask-previews/build-utils": "3.0.2-preview-62a75dc",
  "@metamask-previews/chain-controller": "0.2.2-preview-62a75dc",
  "@metamask-previews/composable-controller": "10.0.0-preview-62a75dc",
  "@metamask-previews/controller-utils": "11.4.5-preview-62a75dc",
  "@metamask-previews/ens-controller": "15.0.1-preview-62a75dc",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-62a75dc",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-62a75dc",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-62a75dc",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-62a75dc",
  "@metamask-previews/keyring-controller": "19.0.2-preview-62a75dc",
  "@metamask-previews/logging-controller": "6.0.3-preview-62a75dc",
  "@metamask-previews/message-manager": "11.0.3-preview-62a75dc",
  "@metamask-previews/multichain": "2.0.0-preview-62a75dc",
  "@metamask-previews/name-controller": "8.0.2-preview-62a75dc",
  "@metamask-previews/network-controller": "22.1.1-preview-62a75dc",
  "@metamask-previews/notification-services-controller": "0.15.0-preview-62a75dc",
  "@metamask-previews/permission-controller": "11.0.5-preview-62a75dc",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-62a75dc",
  "@metamask-previews/phishing-controller": "12.3.1-preview-62a75dc",
  "@metamask-previews/polling-controller": "12.0.2-preview-62a75dc",
  "@metamask-previews/preferences-controller": "15.0.1-preview-62a75dc",
  "@metamask-previews/profile-sync-controller": "3.3.0-preview-62a75dc",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-62a75dc",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-62a75dc",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-62a75dc",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-62a75dc",
  "@metamask-previews/signature-controller": "23.2.0-preview-62a75dc",
  "@metamask-previews/transaction-controller": "42.1.0-preview-62a75dc",
  "@metamask-previews/user-operation-controller": "21.0.0-preview-62a75dc"
}

symbol: 'SOL',
native: true,
fungible: true,
iconBase64:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be an url? We are getting the url from the static api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, it was defined as iconBase64 in this document which i think is different than a url.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this is better to use a base64 here, in case the logo we want to use is not hosted "anywhere".

Also, using "untrusted URLs" seems always """risky""" (I don't have good example for now) 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants