Refactor service classes to use createServicePolicy #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
extract-create-service-policy
branch
from
627b096 to
530bc4c
Compare
mcmire
force-pushed
the
refactor-service-classes
branch
from
1c790a7 to
987ec77
Compare
mcmire
force-pushed
the
refactor-service-classes
branch
from
987ec77 to
778223c
Compare
mcmire
changed the base branch from
extract-create-service-policy
to
extract-create-service-policy-3
mcmire
changed the title
mcmire
force-pushed
the
refactor-service-classes
branch
from
778223c to
9d15cfb
Compare
A previous commit added a `createServicePolicy` function to `controller-utils`. This allows us to refactor the following service classes which make use of a Cockatiel policy by replacing boilerplace code with a simple function call: - `CodefiV2` in `assets-controllers` - `ClientConfigApiService` in `remote-feature-flag-controller` Note that other service modules that do not yet make use of a Cockatiel policy have not been updated to use `createServicePolicy`. We would need to upgrade these areas to use the latest service object pattern we've established.
mcmire
force-pushed
the
refactor-service-classes
branch
from
9d15cfb to
3b0eaff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
A previous commit added a
createServicePolicyfunction tocontroller-utils. This allows us to refactor the following service classes which make use of a Cockatiel policy by replacing boilerplace code with a simple function call:CodefiV2inassets-controllersClientConfigApiServiceinremote-feature-flag-controllerNote that other service modules that do not yet make use of a Cockatiel policy have not been updated to use
createServicePolicy. We would need to upgrade these areas to use the latest service object pattern we've established.References
Closes #4994.
Changelog
(N/A — no consumer-facing changes)
Checklist