chore(accouncement): Rename ControllerMessenger to Messenger
#5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
commented
Dec 20, 2024
There was a problem hiding this comment.
No export changes, they are all preserved. The export was converted to a map in order to more easily add an alias. This way is easier to read anyway.
Gudahtt
changed the title
ControllerMessenger to Messenger.ControllerMessenger to Messenger
Rename `ControllerMessenger` to `Messenger` in the `@metamask/announcement-controller` package. The `AnnouncementControllerMessenger` type export was renamed to `AnnouncementMessenger`, but the old name is preserved as an alias. Relates to #4538
This reverts the sole functional change.
Gudahtt
force-pushed
the
messenger-rename-accouncement
branch
from
5a48ddc to
b3e8ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Rename
ControllerMessengertoMessengerin the@metamask/announcement-controllerpackage. TheAnnouncementControllerMessengertype export was renamed toAnnouncementMessenger, but the old name is preserved as an alias.References
Relates to #4538
Changelog
No functional changes
Checklist