Improving UX by hiding editing buttons for readers of a project #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anging Add button visibility for readers
Pull Request Test Coverage Report for Build 12792939964Details
💛 - Coveralls |
VitorVieiraZ
changed the title
VitorVieiraZ
changed the title
tomasMizera
requested changes
Jan 6, 2025
core/merginprojectmetadata.h
Outdated
| @@ -59,6 +59,8 @@ struct MerginProjectMetadata | |||
| { | |||
| QString name; | |||
| QString projectNamespace; | |||
| QString role; | |||
| QList<QString> writersnames; | |||
There was a problem hiding this comment.
This should not be needed here
| @@ -48,6 +48,8 @@ Item { | |||
| function setupProjectOpen( projectPath ) { | |||
| if ( projectPath === __activeProject.localProject.qgisProjectFilePath ) | |||
| { | |||
| // update user's role in project ( in case user has changed ) | |||
| __activeProject.updateUserRoleInActiveProject() | |||
There was a problem hiding this comment.
This is giving me qml error, the function is not Q_INVOKABLE
tomasMizera
requested changes
Jan 15, 2025
Comment on lines
+3462
to
+3487
| QFile file( metadataPath ); | ||
| if ( !file.open( QIODevice::ReadOnly ) ) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| QByteArray data = file.readAll(); | ||
| file.close(); | ||
|
|
||
| QJsonDocument doc = QJsonDocument::fromJson( data ); | ||
| if ( !doc.isObject() ) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| QJsonObject obj = doc.object(); | ||
| obj["role"] = newRole; | ||
| doc.setObject( obj ); | ||
|
|
||
| if ( !file.open( QIODevice::WriteOnly ) ) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| bool success = ( file.write( doc.toJson() ) != -1 ); | ||
| file.close(); |
There was a problem hiding this comment.
Let's turn this into a CoreUtils::replaceValueInJson method that can then be easily tested. Ideally pass in the name of the key, key value and path to json + autotests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in
Readerrole, editing buttons are no longer visible to user. These buttons include:Main
Addbutton and the one within the features list.Add featurebutton and its variations.Edit featurebutton and its variations.Edit geometrybutton.Resolves #3174