Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to design map items #2852

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Try to design map items #2852

merged 7 commits into from
Nov 14, 2023

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Oct 11, 2023 •
edited
Loading

MapItems
Map objects:

  • clickable: MMMapButton {}
  • text based: MMMapLabel { text: "20.0 m" }

@PeterPetrik PeterPetrik added the FROZEN 🥶 do not merge before upcoming release label Oct 12, 2023
@PeterPetrik PeterPetrik removed the FROZEN 🥶 do not merge before upcoming release label Oct 24, 2023
@iiLubos
Copy link
Contributor Author

iiLubos commented Oct 24, 2023

Ready for review

@iiLubos iiLubos marked this pull request as ready for review October 24, 2023 07:59
PeterPetrik
PeterPetrik reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomasMizera
tomasMizera requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments :)

@iiLubos
Copy link
Contributor Author

iiLubos commented Oct 31, 2023

Applied all the review comments.
Support for an icon inside the Map label.

@iiLubos iiLubos requested a review from tomasMizera November 7, 2023 10:42
tomasMizera
tomasMizera requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bla bla test

@iiLubos iiLubos requested a review from tomasMizera November 7, 2023 14:27
@tomasMizera tomasMizera merged commit 27ba9ad into master Nov 14, 2023
9 of 11 checks passed
@tomasMizera tomasMizera deleted the master_redesign-mapItems branch November 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik PeterPetrik left review comments

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees

@tomasMizera tomasMizera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iiLubos @PeterPetrik @tomasMizera @inputapp-bot