-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate compounds by looking for the "symptoms" of OpenBabel issues #104
Conversation
It seems like the built-in version of OpenBabel included in the windows version of ChemmineOB might behave differently when it comes to creating the formula and InChI that we are using to diagnose parsing issues. Need to add some tests and investigate. |
It looks like this strategy doesn't currently work on Windows because the windows version of |
For now I may just only allow the |
ChemmineOB currently is encountering errors when being built from source on macOS: girke-lab/ChemmineOB#35. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I don't have any comments, thanks for doing all of this work @Aariq.
Ok, going to go ahead and merge despite checks on macOS failing since I've confirmed checks work locally on macOS with binary version of |
Addresses #85 (and also closes #56) by checking the output of
ChemmineR::propOB()
for the symptoms of OpenBabel issues parsing SDFs. WhypropOB()
? Simply because that is the onlyChemmineR
function we have found that actually complains about problems in .mol files.Currently this is tested with two cases:
I'm happy to have this PR merged as-is or add additional tests—I'm sure there are other ways that inputs (.mol files or SMILES) can be just broken enough to trigger OpenBabel errors, but not R errors, and return incorrect results.
Unfortunately, since InChI can't be generated with the windows version of
ChemmineOB
, this validation option can't be used on Windows. This is documented in the help file forget_fx_groups()
and a warning is printed whenvalidate = TRUE
is used on Windows.Still to do?:
validate
to Getting Started vignette