-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Configs To TF-PSA-Crypto #153
Open
Harry-Ramsey
wants to merge
23
commits into
Mbed-TLS:development
Choose a base branch
from
Harry-Ramsey:move-configs-to-tf-psa-crypto
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move Configs To TF-PSA-Crypto #153
Harry-Ramsey
wants to merge
23
commits into
Mbed-TLS:development
from
Harry-Ramsey:move-configs-to-tf-psa-crypto
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a reference configuration with most symmetric cryptographic algorithms enabled, but without any asymmetric cryptography. This checks that we don't have spurious unexpected dependencies on asymmetric-only modules such as bignum. Keep HAVE_ASM disabled because it's platform-specific. Keep HAVEGE disabled because it's untested and not recommended. Keep MEMORY_BUFFER_ALLOC out because it isn't related to cryptography at all and it makes memory sanitizers ineffective. Keep THREADING disabled because it requires special build options.
As a result, the copyright of contributors other than Arm is now acknowledged, and the years of publishing are no longer tracked in the source files. Also remove the now-redundant lines declaring that the files are part of MbedTLS. This commit was generated using the following script: # ======================== #!/bin/sh # Find files find '(' -path './.git' -o -path './3rdparty' ')' -prune -o -type f -print | xargs sed -bi ' # Replace copyright attribution line s/Copyright.*Arm.*/Copyright The Mbed TLS Contributors/I # Remove redundant declaration and the preceding line $!N /This file is part of Mbed TLS/Id P D ' # ======================== Signed-off-by: Bence Szépkúti <[email protected]>
Since the symmetric only reference config is utilizing PSA crypto library builds, the config file needs to included the new config_psa.h so that all the PSA feature macros are setup properly for the test. Signed-off-by: John Durkop <[email protected]>
Signed-off-by: Mateusz Starzyk <[email protected]>
Although SHA512 is currently required to enable SHA384, this is expected to change in the future. This commit is an intermediate step towards fully separating SHA384 and SHA512. check_config is the only module which enforces that SHA512 is enabled together with SHA384. Signed-off-by: Mateusz Starzyk <[email protected]>
These options are still dependant on each other. This is an intermediate step. Signed-off-by: Mateusz Starzyk <[email protected]>
Rework SHA224 and SHA283 documentation. Define MBEDTLS_SHAxxx_C options in alphabetic order. Fix SHA224 and SHA384 dependencies in test suites. Signed-off-by: Mateusz Starzyk <[email protected]>
Rephrase config.h documentation and add a note to template configs. Signed-off-by: Mateusz Starzyk <[email protected]>
Signed-off-by: Mateusz Starzyk <[email protected]>
Signed-off-by: Bence Szépkúti <[email protected]>
Signed-off-by: TRodziewicz <[email protected]>
Signed-off-by: Bence Szépkúti <[email protected]>
Also remove them from the example configs, but keep the one in mbedtls_config.h. Signed-off-by: Bence Szépkúti <[email protected]>
…tion and comments. Signed-off-by: Fredrik Hesse <[email protected]>
Add change log and non-regression test for CCM* with no tag not supported in CCM only configuration. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Yanray Wang <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Move all changes local to Mbed TLS into config-tfm.h (except for commenting out a couple of #include's). Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Harry-Ramsey
force-pushed
the
move-configs-to-tf-psa-crypto
branch
from
January 13, 2025 14:35
e299112
to
ea6c3d0
Compare
Harry-Ramsey
force-pushed
the
move-configs-to-tf-psa-crypto
branch
3 times, most recently
from
January 14, 2025 11:12
fe27f23
to
74e91af
Compare
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Harry-Ramsey
force-pushed
the
move-configs-to-tf-psa-crypto
branch
from
January 14, 2025 11:18
74e91af
to
925ed73
Compare
This commit updates configs/README.txt and configs/ext/README.md to reflect the necessary files which were moved to TF-PSA-Crypto. Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
force-pushed
the
move-configs-to-tf-psa-crypto
branch
from
January 14, 2025 11:48
0ea444c
to
03aebfb
Compare
5 tasks
Harry-Ramsey
added
enhancement
New feature or request
size-s
Estimated task size: small (~2d)
needs-review
Every commit must be reviewed by at least two team members
needs-reviewer
This PR needs someone to pick it up for review
and removed
DO-NOT-MERGE
labels
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
needs-review
Every commit must be reviewed by at least two team members
needs-reviewer
This PR needs someone to pick it up for review
size-s
Estimated task size: small (~2d)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move related crypto configs to TF-PSA-Crypto from Mbed TLS. Closes #9879.
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: