$OIDC_SCOPES must be an array, should not be in quotes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay before pushing to config (without escaping)
|
Makes sense to me. Looking back, my original PR (https://github.com/MISP/misp-docker/pull/170/files) did not include quotes, but it also made the field mandatory, and the quotes were added as part of another PR (https://github.com/MISP/misp-docker/pull/180/files). |
|
@Diogo-Rego can you give it a look? |
ostefano
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OIDC_SCOPES (OidcAuth.scopes) should not be quoted before setting to config, as it expects a JSON array. As there's
jqavailable at the container, we can properly test if the variable is indeed an array before pushing to config