-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Torch Multiprocessing in nnUNet for Improved Security and Compatibility #2614
base: master
Are you sure you want to change the base?
Conversation
New environment variables: - nnUNet_npp - nnUNet_nps Default values remain unchanged, cli parameter -npp and -nps overwrite environment variables if set.
@FabianIsensee I have noticed some (significant) differences between |
Hey, thanks for the PR and sorry for being slow. I have too much on my plate. Can you please provide more information on the inconsistency in performance? What is the difference between the runs? This doesn't become quite clear from your message |
Hey @FabianIsensee thanks for the reply and no worries!
Good point! @surajpaib Looks like we can combine it to output each item right after preprocessing.
I ran some tests (with this submission model). All MHub models come with test and reference data, so I manually updated the version from |
Is there a way I can reproduce this locally to investigate? Like can you share both checkpoints + the reference data that gives Dice=1 in one case and 0.94 in the other? That way I can track down where things diverge |
This PR resolves #2556.
-npp
and-nps
We have done some internal testing and get identical results between the latest
nnunetv2==2.5.1
and with our proposed patch.