Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of test for missing aggregation function when require_all_aggregators=True #4770

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

talagayev
Copy link
Member

@talagayev talagayev commented Oct 28, 2024

Fixes #4650

Changes made in this Pull Request:

  • Addition of test_missing_aggregator in test_results.py to cover ValueError case when
    the aggregation is missing and require_all_aggregators=True in ResultsGroup.merge()

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4770.org.readthedocs.build/en/4770/

Added test_missing_aggregator to cover the raisevalue error that requires the aggregators
@pep8speaks
Copy link

pep8speaks commented Oct 28, 2024

Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-26 07:54:52 UTC

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (c48962e) to head (a554d3b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4770      +/-   ##
===========================================
- Coverage    93.66%   93.65%   -0.02%     
===========================================
  Files          177      189      +12     
  Lines        21742    22808    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20365    21360     +995     
- Misses         930     1001      +71     
  Partials       447      447              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuxuanzhuang yuxuanzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just waiting for the CI.

@talagayev
Copy link
Member Author

Nice, much appreciated :)

@yuxuanzhuang yuxuanzhuang merged commit 277f8ee into MDAnalysis:develop Nov 26, 2024
23 of 24 checks passed
@talagayev talagayev deleted the test_missing_aggregator branch November 26, 2024 21:32
@IAlibay
Copy link
Member

IAlibay commented Nov 26, 2024

@yuxuanzhuang we really shouldn't have merged things "in between releases"..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test missing aggregation function when require_all_aggregators=True
5 participants