[CI] MDAnalysis self-dependency build fix #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4502 +/- ##
===========================================
+ Coverage 93.62% 93.84% +0.21%
===========================================
Files 173 185 +12
Lines 21422 22488 +1066
Branches 3979 3979
===========================================
+ Hits 20056 21103 +1047
- Misses 903 931 +28
+ Partials 463 454 -9 ☔ View full report in Codecov by Sentry. |
5 tasks
|
Cron failures are good - they are pointing out to an existing issue that needs fixing in our conda-forge package. |
|
conda-forge tests are now just related to rdkit - this is a known failure (and fixed in develop), nothing else to do here. |
yuxuanzhuang
reviewed
Sep 7, 2024
| @@ -4,6 +4,11 @@ on: | |||
| # 3 am Tuesdays and Fridays | |||
| - cron: "0 3 * * 2,5" | |||
| workflow_dispatch: | |||
| # Uncomment when you need to test on a PR | |||
| pull_request: | |||
There was a problem hiding this comment.
Ah completely forgot to do this!
5 tasks
RMeli
pushed a commit
to RMeli/mdanalysis
that referenced
this pull request
Oct 3, 2024
* Fix MDAnalysis cron CI * Fix deployment workflow python and utility versions * Make sure we install mdakit dependencies using no-deps * Fix nightly wheel tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4492
Work in progress:
TODO:
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4502.org.readthedocs.build/en/4502/