Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding arm64-osx to gh deploy action #4445

Merged
merged 3 commits into from
Feb 4, 2024
Merged

Adding arm64-osx to gh deploy action #4445

merged 3 commits into from
Feb 4, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 31, 2024

Following up from @RMeli's PR on #4442

I would suggest keeping the cirrus tooling as a backup for now, maybe we can look to remove eventually.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4445.org.readthedocs.build/en/4445/

Copy link

github-actions bot commented Jan 31, 2024

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ba7682) 93.37% compared to head (8b5f7c0) 93.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4445     +/-   ##
==========================================
  Coverage    93.37%   93.38%             
==========================================
  Files          171      185     +14     
  Lines        21737    22851   +1114     
  Branches      4012     4012             
==========================================
+ Hits         20298    21339   +1041     
- Misses         952     1025     +73     
  Partials       487      487             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Jan 31, 2024

Support for macos-14 gh actions arm64 is "experimental" as of the latest version of cibuildwheel, but looks like it's working?

@IAlibay IAlibay changed the title Try adding arm64-osx to gh deploy action Adding arm64-osx to gh deploy action Jan 31, 2024
@IAlibay IAlibay marked this pull request as ready for review February 3, 2024 21:18
@IAlibay
Copy link
Member Author

IAlibay commented Feb 3, 2024

This is good to go.

@IAlibay IAlibay merged commit c4ffb7e into develop Feb 4, 2024
22 of 23 checks passed
@IAlibay IAlibay deleted the osx-arm64-deploy branch February 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants