Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies #59

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Remove dependencies #59

merged 1 commit into from
Oct 3, 2024

Conversation

wilwade
Copy link
Member

@wilwade wilwade commented Oct 3, 2024

Reduced the non-dev dependencies by changing getSchemaId to take the genesis hash instead of an ApiPromise

Problem

Keeping the Polkadot/api libraries in version sync is difficult and issues arise with dependencies in typescript with the additional requirement that @frequency-chain/api-augment versions align.

Solution

Removed the dependency need.

@wilwade wilwade requested a review from wesbiggs October 3, 2024 18:27
@@ -18,19 +18,16 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/LibertyDSNP/schemas.git"
"url": "git+https://github.com/LibertyDSNP/frequency-schemas.git"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.

Copy link
Member

@wesbiggs wesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wilwade wilwade merged commit a28ca1a into main Oct 3, 2024
1 check passed
@wilwade wilwade deleted the feature/reduce-depenencies branch October 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants