Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lsst.meas.algorithms function to remove Poisson noise #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MorganSchmitz
Copy link
Member

Will require the changes in this PR to be merged (and included in the weekly version of the stack we run this code against).

Two changes:

  • estimates the gain as a linear fit of image vs variance planes (instead of relying on getGain)
  • does this on a per-amplifier basis

@esheldon
Copy link
Collaborator

Thanks Morgan

@esheldon
Copy link
Collaborator

esheldon commented Dec 10, 2021

Morgan you should have the option to rerun the unit tests in the CI. Can you please give it a try?

@MorganSchmitz
Copy link
Member Author

MorganSchmitz commented Dec 14, 2021

Hey Erin,

I tried but could not find the "re-run jobs" button.

Note it would have still crashed at the import since I haven't gotten round to wrapping up my PR on the DM side (sorry! my classes started and getting them ready from one week to the next has been taking up pretty much all of my time lately). I am not sure if you wanted me to rerun them anyway to test that I could actually do it?

@esheldon
Copy link
Collaborator

esheldon commented Dec 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants