Bug in Despali16

[damonge]

Closes #1195
This bug was not caught by our tests because it would only show up when the chosen mass definition differs from Delta_vir.

[damonge]

I've added a benchmark test that would have caught this bug. In doing so I regenerated all our benchmark files for halo mass function and halo biases using the latest version of colossus. The changes do not affect our benchmarks, which remain sufficiently accurate.

[damonge]

Unrelated to this, there have been modifications to velocileptors which required me to update those benchmarks too.

Sorry for the many file modifications. Most of them are benchmark data, so any review should only focus on the code modifications (which are very small).

[coveralls]

Pull Request Test Coverage Report for Build 10681318177

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.464%

---

Totals
Change from base Build 9990842930:	0.0%
Covered Lines:	6611
Relevant Lines:	6783

---

💛 - Coveralls

[combet]

I've looked at the changes in the code, cross-checking the coefficients with the Despali paper and the fix looks good. Also good to have an additional benchmark to catch anything going wrong if the mass definition is not in Delta_vir.