Expose mask methods for scatter bugfix 2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not run CUDA tests if GPU not available
…yneRBI#1284) * got rid of code overlaps in computing gradients of objective functions * slimmed C interface for computing gradients of objective functions
* prior value now double, fixes SyneRBI#1290 * [ci skip] updated CHANGES.md
…IRF-object ScatterEstimator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a PR from Kris' branch to SyneRBI: SyneRBI#1280 , but there, the methods were not exposed to the SIRF python object "ScatterEstimator" itself.
I've corrected this here: src/xSTIR/pSTIR/STIR.py
Note 1: I merged master into my branch to make sure I have the latest version. The only file I changed myself is the STIR.py. Sorry!
Note 2: In SyneRBI@f3fabf8 you added a STIR version check before exposing the method "recompute mask image". As I didn't know how to implement a STIR version check in python, some more work needs to be done, and help would be appreciated.
Thank you!