chore: Switch Elixir tests back to pipes #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of elixir-lang/elixir#14136, I learned about MIX_QUIET, to suppress `Mix.shell()` output. Using this would not have worked with the generator, but the generator was using `Mix.shell.info/1` to output the JSON suite data. Changing that to `IO.write(:stdio, …)` means that we can use `MIX_QUIET=1` for our tests. Running this manually with Elixir 1.18.0 will still fail unless `MIX_QUIET=1` is specified, but Elixir 1.18.1 or later will have this fixed because the lock warnings are written to stderr instead of stdout. Signed-off-by: Austin Ziegler <[email protected]>
halostatue
force-pushed
the
restore-elixir-pipe-tests
branch
from
f7d6cd1 to
4134b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of elixir-lang/elixir#14136, I learned about MIX_QUIET, to suppress
Mix.shell()output. Using this would not have worked with the generator, but the generator was usingMix.shell.info/1to output the JSON suite data. Changing that toIO.write(:stdio, …)means that we can useMIX_QUIET=1for our tests.Running this manually with Elixir 1.18.0 will still fail unless
MIX_QUIET=1is specified, but Elixir 1.18.1 or later will have this fixed because the lock warnings are written to stderr instead of stdout.