Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scoring logic: CSProgram, Iframe, and Dropdown #2111

Open
wants to merge 3 commits into
base: LEMS-2737/radio
Choose a base branch
from

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jan 15, 2025

Summary:

Decided to do 3, since they're all pretty simple

  • CSProgram
  • Iframe
  • Dropdown

Issue: LEMS-2737

Test plan:

Nothing should change, moving code

@handeyeco handeyeco self-assigned this Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (5b72ed9) and published it to npm. You
can install it using the tag PR2111.

Example:

yarn add @khanacademy/perseus@PR2111

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2111

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Size Change: -90 B (-0.01%)

Total Size: 1.47 MB

Filename Size Change
packages/perseus-score/dist/es/index.js 107 kB +299 B (+0.28%)
packages/perseus/dist/es/index.js 407 kB -389 B (-0.1%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 83.1 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 23.1 kB
packages/perseus-editor/dist/es/index.js 689 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 4.85 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@handeyeco handeyeco changed the title cs-program Move scoring logic: CSProgram, Iframe, and Dropdown Jan 15, 2025
@handeyeco handeyeco marked this pull request as ready for review January 15, 2025 15:58
@handeyeco handeyeco requested review from a team January 15, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant