Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cr.yml #71

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Update cr.yml #71

merged 1 commit into from
Jan 19, 2024

Conversation

linglong67
Copy link
Collaborator

@linglong67 linglong67 commented Jan 19, 2024

πŸ’‘ Motivation and Context

GPTκ°€ ν•œκΈ€ 리뷰λ₯Ό μ•ˆ ν•΄μ€˜μš”...


πŸ”¨ Modified

cr.yml ν”„λ‘¬ν”„νŠΈ μˆ˜μ •

  • ν”„λ‘¬ν”„νŠΈ λ‚΄μš© λ³€κ²½
  • 쀑간 주석 μ‚­μ œ

🌟 More

  • λ‹€μŒ PR λ•Œ μ œλŒ€λ‘œ ν•˜λŠ”μ§€ μ§€μΌœλ³΄κ² μŠ΅λ‹ˆλ‹€..


πŸ“‹ 컀밋 μ „ 체크리슀트

  • μΆ”κ°€/변경에 λŒ€ν•œ λ‹¨μœ„ ν…ŒμŠ€νŠΈλ₯Ό μ™„λ£Œν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ»¨λ²€μ…˜μ— 맞게 μž‘μ„±ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

🀟🏻 PR둜 μ™„λ£Œλœ 이슈

closes #

LANGUAGE: Korean
PROMPT: 당신은 10λ…„μ°¨ μ‹œλ‹ˆμ–΄ κ°œλ°œμžμž…λ‹ˆλ‹€. μš°λ¦¬κ°€ μž‘μ„±ν•œ μ½”λ“œμ— λ¬Έμ œκ°€ μ—†λŠ”μ§€ λ¦¬λ·°ν•΄μ£Όμ„Έμš”. λŒ€λ‹΅μ€ ν•œκ΅­μ–΄λ‘œ μž‘μ„±ν•΄μ£Όμ‹œκ³  λ‹¨μˆœν•œ λΆ€λΆ„μ΄λ‚˜ 큰 μ΄μŠˆκ°€ μ—†λŠ” 뢀뢄은 리뷰해주지 μ•Šμ•„λ„ λ˜μš”.
PROMPT: 당신은 λŠ₯λ ₯ μžˆλŠ” 10λ…„μ°¨ μ‹œλ‹ˆμ–΄ κ°œλ°œμžλ‘œμ„œ ν”„λ‘œμ νŠΈμ˜ μ½”λ“œ 리뷰λ₯Ό λ‹΄λ‹Ήν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. μ½”λ“œ λ¦¬λ·°λŠ” ν•œκ΅­μ–΄λ‘œ μž‘μ„±ν•˜κ³  λ‹¨μˆœν•˜κ±°λ‚˜ 큰 μ΄μŠˆκ°€ μ—†λ‹€λ©΄ ꡳ이 λ¦¬λ·°ν•˜μ§€ μ•Šμ•„λ„ λ©λ‹ˆλ‹€. μΆ”κ°€λ‘œ μ½”λ“œ 리뷰λ₯Ό ν•  λ•Œ 일일이 μ„€λͺ…ν•˜μ§€ μ•Šκ³  κΌ­ ν•„μš”ν•œ λΆ€λΆ„λ§Œ μ§šμ–΄μ„œ 짧게 μ„€λͺ…해주셔도 λ©λ‹ˆλ‹€.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the code patch you provided, here are some observations:

  1. The commented line # optional appears to be unnecessary and can be removed.

  2. The LANGUAGE environment variable is set to "Korean," indicating the preferred language for the response. This seems appropriate.

  3. The PROMPT environment variable is updated to provide more specific instructions for the code review. You've mentioned that the code review should be done in Korean, and if there are no simple or major issues, there's no need to review them. Additionally, reviewers are encouraged to provide brief explanations when necessary. The new prompt text seems clear and concise.

  4. Overall, the code patch looks fine and doesn't appear to introduce any bugs. It enhances clarity and provides better instructions for the code review process.

Remember to test your code thoroughly, especially after making changes, to ensure it functions as expected.

LANGUAGE: Korean
PROMPT: 당신은 10λ…„μ°¨ μ‹œλ‹ˆμ–΄ κ°œλ°œμžμž…λ‹ˆλ‹€. μš°λ¦¬κ°€ μž‘μ„±ν•œ μ½”λ“œμ— λ¬Έμ œκ°€ μ—†λŠ”μ§€ λ¦¬λ·°ν•΄μ£Όμ„Έμš”. λŒ€λ‹΅μ€ ν•œκ΅­μ–΄λ‘œ μž‘μ„±ν•΄μ£Όμ‹œκ³  λ‹¨μˆœν•œ λΆ€λΆ„μ΄λ‚˜ 큰 μ΄μŠˆκ°€ μ—†λŠ” 뢀뢄은 리뷰해주지 μ•Šμ•„λ„ λ˜μš”.
PROMPT: 당신은 λŠ₯λ ₯ μžˆλŠ” 10λ…„μ°¨ μ‹œλ‹ˆμ–΄ κ°œλ°œμžλ‘œμ„œ ν”„λ‘œμ νŠΈμ˜ μ½”λ“œ 리뷰λ₯Ό λ‹΄λ‹Ήν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. μ½”λ“œ λ¦¬λ·°λŠ” ν•œκ΅­μ–΄λ‘œ μž‘μ„±ν•˜κ³  λ‹¨μˆœν•˜κ±°λ‚˜ 큰 μ΄μŠˆκ°€ μ—†λ‹€λ©΄ ꡳ이 λ¦¬λ·°ν•˜μ§€ μ•Šμ•„λ„ λ©λ‹ˆλ‹€. μΆ”κ°€λ‘œ μ½”λ“œ 리뷰λ₯Ό ν•  λ•Œ 일일이 μ„€λͺ…ν•˜μ§€ μ•Šκ³  κΌ­ ν•„μš”ν•œ λΆ€λΆ„λ§Œ μ§šμ–΄μ„œ 짧게 μ„€λͺ…해주셔도 λ©λ‹ˆλ‹€.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 λΆ€λΆ„μ˜ μˆ˜μ • μ‚¬ν•­μœΌλ‘œ ν™•μΈλ˜λŠ” 뢀뢄은 λ‹€μŒκ³Ό κ°™μŠ΅λ‹ˆλ‹€:

  • 기쑴에 μ£Όμ„μœΌλ‘œ λ‹΄κ²¨μžˆλ˜ λ‚΄μš©μ΄ μ½”λ“œ 리뷰의 λͺ©μ  및 μš”μ²­ 방법과 κ΄€λ ¨ν•˜μ—¬ μˆ˜μ •λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
  • "LANGUAGE" ν™˜κ²½ λ³€μˆ˜λ‘œ "Korean" 값을 μ „λ‹¬ν•˜λ„λ‘ λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
  • "PROMPT" ν™˜κ²½ λ³€μˆ˜μ˜ λ‚΄μš©μ΄ μ„ΈλΆ€μ μœΌλ‘œ λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€. μ΄μ œλŠ” μ½”λ“œ 리뷰λ₯Ό μ§„ν–‰ν•˜λŠ” κ°œλ°œμžλ‘œμ„œμ˜ μ—­ν• κ³Ό κ΄€λ ¨ν•˜μ—¬ ꡬ체적인 λ‚΄μš©μ΄ μΆ”κ°€λ˜μ—ˆμœΌλ©°, μ½”λ“œ 리뷰 μ‹œ μ„€λͺ…에 λŒ€ν•œ κ°„λž΅ν•œ μš”κ΅¬μ‚¬ν•­μ΄ μžˆμŒμ„ μ•Œλ €μ€λ‹ˆλ‹€.

@linglong67 linglong67 merged commit c7c02a5 into develop Jan 19, 2024
1 check passed
@linglong67 linglong67 self-assigned this Jan 19, 2024
@linglong67 linglong67 deleted the linglong67-patch-1 branch January 19, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant