-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cr.yml #71
Update cr.yml #71
Conversation
LANGUAGE: Korean | ||
PROMPT: λΉμ μ 10λ μ°¨ μλμ΄ κ°λ°μμ λλ€. μ°λ¦¬κ° μμ±ν μ½λμ λ¬Έμ κ° μλμ§ λ¦¬λ·°ν΄μ£ΌμΈμ. λλ΅μ νκ΅μ΄λ‘ μμ±ν΄μ£Όμκ³ λ¨μν λΆλΆμ΄λ ν° μ΄μκ° μλ λΆλΆμ 리뷰ν΄μ£Όμ§ μμλ λμ. | ||
PROMPT: λΉμ μ λ₯λ ₯ μλ 10λ μ°¨ μλμ΄ κ°λ°μλ‘μ νλ‘μ νΈμ μ½λ 리뷰λ₯Ό λ΄λΉνκ³ μμ΅λλ€. μ½λ 리뷰λ νκ΅μ΄λ‘ μμ±νκ³ λ¨μνκ±°λ ν° μ΄μκ° μλ€λ©΄ κ΅³μ΄ λ¦¬λ·°νμ§ μμλ λ©λλ€. μΆκ°λ‘ μ½λ 리뷰λ₯Ό ν λ μΌμΌμ΄ μ€λͺ νμ§ μκ³ κΌ νμν λΆλΆλ§ μ§μ΄μ μ§§κ² μ€λͺ ν΄μ£Όμ λ λ©λλ€. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the code patch you provided, here are some observations:
-
The commented line
# optional
appears to be unnecessary and can be removed. -
The
LANGUAGE
environment variable is set to "Korean," indicating the preferred language for the response. This seems appropriate. -
The
PROMPT
environment variable is updated to provide more specific instructions for the code review. You've mentioned that the code review should be done in Korean, and if there are no simple or major issues, there's no need to review them. Additionally, reviewers are encouraged to provide brief explanations when necessary. The new prompt text seems clear and concise. -
Overall, the code patch looks fine and doesn't appear to introduce any bugs. It enhances clarity and provides better instructions for the code review process.
Remember to test your code thoroughly, especially after making changes, to ensure it functions as expected.
LANGUAGE: Korean | ||
PROMPT: λΉμ μ 10λ μ°¨ μλμ΄ κ°λ°μμ λλ€. μ°λ¦¬κ° μμ±ν μ½λμ λ¬Έμ κ° μλμ§ λ¦¬λ·°ν΄μ£ΌμΈμ. λλ΅μ νκ΅μ΄λ‘ μμ±ν΄μ£Όμκ³ λ¨μν λΆλΆμ΄λ ν° μ΄μκ° μλ λΆλΆμ 리뷰ν΄μ£Όμ§ μμλ λμ. | ||
PROMPT: λΉμ μ λ₯λ ₯ μλ 10λ μ°¨ μλμ΄ κ°λ°μλ‘μ νλ‘μ νΈμ μ½λ 리뷰λ₯Ό λ΄λΉνκ³ μμ΅λλ€. μ½λ 리뷰λ νκ΅μ΄λ‘ μμ±νκ³ λ¨μνκ±°λ ν° μ΄μκ° μλ€λ©΄ κ΅³μ΄ λ¦¬λ·°νμ§ μμλ λ©λλ€. μΆκ°λ‘ μ½λ 리뷰λ₯Ό ν λ μΌμΌμ΄ μ€λͺ νμ§ μκ³ κΌ νμν λΆλΆλ§ μ§μ΄μ μ§§κ² μ€λͺ ν΄μ£Όμ λ λ©λλ€. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ£Όμ λΆλΆμ μμ μ¬νμΌλ‘ νμΈλλ λΆλΆμ λ€μκ³Ό κ°μ΅λλ€:
- κΈ°μ‘΄μ μ£ΌμμΌλ‘ λ΄κ²¨μλ λ΄μ©μ΄ μ½λ 리뷰μ λͺ©μ λ° μμ² λ°©λ²κ³Ό κ΄λ ¨νμ¬ μμ λμμ΅λλ€.
- "LANGUAGE" νκ²½ λ³μλ‘ "Korean" κ°μ μ λ¬νλλ‘ λ³κ²½λμμ΅λλ€.
- "PROMPT" νκ²½ λ³μμ λ΄μ©μ΄ μΈλΆμ μΌλ‘ λ³κ²½λμμ΅λλ€. μ΄μ λ μ½λ 리뷰λ₯Ό μ§ννλ κ°λ°μλ‘μμ μν κ³Ό κ΄λ ¨νμ¬ κ΅¬μ²΄μ μΈ λ΄μ©μ΄ μΆκ°λμμΌλ©°, μ½λ 리뷰 μ μ€λͺ μ λν κ°λ΅ν μꡬμ¬νμ΄ μμμ μλ €μ€λλ€.
π‘ Motivation and Context
GPTκ° νκΈ λ¦¬λ·°λ₯Ό μ ν΄μ€μ...
π¨ Modified
π More
π μ»€λ° μ 체ν¬λ¦¬μ€νΈ
π€π» PRλ‘ μλ£λ μ΄μ
closes #