Feature/docker #33
Merged
Feature/docker #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyunJunSon
requested review from
linglong67,
chan99k and
gunsight1
as code owners
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
gunsight1
approved these changes
Jan 5, 2024
chan99k
reviewed
Jan 6, 2024
| @@ -31,10 +31,12 @@ jobs: | |||
|
|
|||
| # Gradle Build๋ฅผ ์ํ ๊ถํ ๋ถ์ฌ | |||
| - name: Grant execute permission for gradlew | |||
| working-directory: ./module-api | |||
There was a problem hiding this comment.
working-directory์ depth ๋ฌธ์ ์๋ค๋ ๊ฒ์ด๊ตฐ์. ๊ณ ์ํ์ จ์ต๋๋ค.
| @@ -15,12 +15,12 @@ public class Brand extends BaseEntity { | |||
| @SequenceGenerator(name = "brand_id_gen", sequenceName = "brand_brand_no_seq") | |||
| @Column(name = "brand_no", nullable = false) | |||
| private Integer brandNo; | |||
| @Column(name = "brand_name", nullable = false) | |||
| @Column(name = "brand_name", nullable = false, length = Integer.MAX_VALUE) | |||
There was a problem hiding this comment.
length๋ฅผ Integer.MAX_VALUE๋ก ์ก์ผ์ ์ด์ ๊ฐ ์๋์?
linglong67
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก Motivation and Context
์ฌ๊ธฐ์ ์ ์ด PR์ด ํ์ํ๋์ง, PR์ ํตํด ๋ฌด์์ด ๋ฐ๋๋์ง์ ๋ํด์ ์ค๋ช ํด ์ฃผ์ธ์๐จ Modified
๐ More
๐ ์ปค๋ฐ ์ ์ฒดํฌ๋ฆฌ์คํธ
๐ค๐ป PR๋ก ์๋ฃ๋ ์ด์
closes #