Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbo refactoring #830

Closed
wants to merge 2 commits into from
Closed

Turbo refactoring #830

wants to merge 2 commits into from

Conversation

govza
Copy link
Contributor

@govza govza commented Jan 15, 2025

Speed up significantly all commands by using turbo features.

* denotes required fields

Priority*

  • High: This PR needs to be merged first, before other tasks.
  • Medium: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

Get rid of all chained commands like
"e2e": "pnpm build && pnpm zip && turbo e2e", and use turbo tasks with dependencies graph.

Changes*

How to check the feature

run pnpm build and check dist/manifest doesn't contain gecko fields of the Firefox environment
run pnpm build:firefox and check dist/manifest conatins gecko fields

run pnpm zip and check in dist-zip chrome zip package is generated
run pnpm zip:firefox and check in dist-zip xpi package

run e2e tests run for chrome
run e2e:firefox tests run for firefox

Reference

https://turbo.build/repo/docs/reference/configuration#extends

https://turbo.build/repo/docs/reference/configuration#globaldependencies
https://turbo.build/repo/docs/reference/configuration#globalenv

@govza govza requested a review from Jonghakseo as a code owner January 15, 2025 11:32
@govza govza marked this pull request as draft January 15, 2025 11:33
@govza govza force-pushed the Turbo-refactoring branch from ea567d7 to be6536f Compare January 15, 2025 11:45
@Jonghakseo Jonghakseo changed the base branch from main to dev January 16, 2025 13:41
@govza govza closed this Jan 16, 2025
@govza govza deleted the Turbo-refactoring branch January 16, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant