Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/create better solution for env vars #725

Draft
wants to merge 32 commits into
base: dev
Choose a base branch
from
Draft

feat/create better solution for env vars #725

wants to merge 32 commits into from

Conversation

PatrykKuniczak
Copy link
Collaborator

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I've decided to fix issue about import.meta.env by solution with only process.env because i hope this will be more simple, to have only one instance with all envs

Changes*

I've removed vite env solution and replace it with process.env

How to check the feature

Try to add env(Read docs about it) and try to access it anywhere

@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch 3 times, most recently from 3ac79d7 to 4c03d1a Compare September 11, 2024 20:59
@PatrykKuniczak PatrykKuniczak linked an issue Sep 12, 2024 that may be closed by this pull request
Create custom solution for env #722
Open
@PatrykKuniczak PatrykKuniczak added the enhancement New feature or request label Dec 18, 2024
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch from 4c03d1a to 2ef32ce Compare December 28, 2024 16:41
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch from 2ef32ce to b9e9e79 Compare January 12, 2025 13:24
@PatrykKuniczak PatrykKuniczak changed the base branch from main to dev January 12, 2025 13:24
@PatrykKuniczak PatrykKuniczak mentioned this pull request Jan 14, 2025
Merged
3 tasks
@PatrykKuniczak
chore: create script for automatic creating .env file and update RE…
3673448 
…ADME
@PatrykKuniczak
chore: create script for load env from CLI into .env
57d458b
@PatrykKuniczak
chore: create more validation for set_global_env.sh
80abe5e
@PatrykKuniczak
fix: remove unnecessary else from copy_env.sh
e1c885e
@PatrykKuniczak
chore: add with-env script to root package.json
5994698
@PatrykKuniczak
chore: update readme Env Vars section
bc66215
@PatrykKuniczak
fix: remove type-check from build and remove cross-env where I've for…
7ad4385 
…gotten
@PatrykKuniczak
chore: add move explanation about CLI env setting to README.md
c394c0f
@PatrykKuniczak
chore: add node type for all modules tsconfig.json
6c08482
@PatrykKuniczak
chore: add patterns for globalEnv for turbo
2044716
@PatrykKuniczak
chore: rename example env
489c19c
@PatrykKuniczak
chore: update README.md for new approach
f3bd1b1
@PatrykKuniczak
chore: update set_global_env.sh script to the new prefixes CLI_CEB an…
ef8682d 
…d CEB_
@PatrykKuniczak
chore: update README.md for new approach
7fd79fa
@PatrykKuniczak
chore: remove with-env and replace old env values
179dd59
@PatrykKuniczak
chore: rename CI env to new pattern
13032a0
@PatrykKuniczak
fix: change last forgotten __FIREFOX__ env
d5a16ff
@PatrykKuniczak
chore: create base-dev script and remove unnecessary staff from e2e
d3c5fc0
@PatrykKuniczak
fix: add missing info for README.md
033a923
@PatrykKuniczak
fix: add missing CLI_CEB_* pattern for turbo.json
9a0e3e2
@PatrykKuniczak
fix: resolve pnpm-lock.yaml conflicts
fad718b
@PatrykKuniczak PatrykKuniczak force-pushed the feat/create-custom-env-solution-for-modules branch from b9e9e79 to a327ab4 Compare January 15, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonghakseo Jonghakseo Awaiting requested review from Jonghakseo Jonghakseo will be requested when the pull request is marked ready for review Jonghakseo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create custom solution for env
1 participant
@PatrykKuniczak