Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-cedarling): add to decision log diagnostic info #10581

Merged
merged 4 commits into from
Jan 13, 2025
Merged

feat(jans-cedarling): add to decision log diagnostic info #10581

merged 4 commits into from
Jan 13, 2025

Conversation

olehbozhok
Copy link
Contributor

@olehbozhok olehbozhok commented Jan 10, 2025 •
edited by mo-auto
Loading

Prepare

Description

Target issue

link

closes #issue-number-here

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #10582,

@olehbozhok olehbozhok requested review from duttarnab, rmarinn and abaghinyan and removed request for duttarnab and rmarinn January 10, 2025 01:33
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Jan 10, 2025
@mo-auto
Copy link
Member

mo-auto commented Jan 10, 2025

Error: Hi @olehbozhok, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request Jan 10, 2025
Closed
djellemah
djellemah approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@djellemah djellemah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiagnosticRefs is not wonderful, but I'm not seeing a better way.

@olehbozhok olehbozhok merged commit 6f8dc7c into main Jan 13, 2025
7 of 8 checks passed
@olehbozhok olehbozhok deleted the jans-cedaling-issue-10578 branch January 13, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abaghinyan abaghinyan abaghinyan approved these changes

@djellemah djellemah djellemah approved these changes

@duttarnab duttarnab Awaiting requested review from duttarnab

@rmarinn rmarinn Awaiting requested review from rmarinn

@nynymike nynymike Awaiting requested review from nynymike

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: feat(jans-cedarling): add to decision log diagnostic info -autocreated
4 participants
@olehbozhok @mo-auto @djellemah @abaghinyan