Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jans-cedarling): make tokens optional #10555

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Conversation

SafinWasi
Copy link
Contributor

Prepare


Description

Target issue

closes #10461 and closes #10462

Implementation Details


Test and Document the changes

  • Add rudimentary tests

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@SafinWasi SafinWasi marked this pull request as ready for review January 15, 2025 15:46
@SafinWasi SafinWasi requested a review from abaghinyan January 15, 2025 15:59
@SafinWasi SafinWasi requested review from moabu and removed request for moabu January 15, 2025 17:48
@SafinWasi SafinWasi enabled auto-merge (squash) January 15, 2025 18:06
@moabu moabu disabled auto-merge January 16, 2025 10:18
@moabu moabu merged commit 80bdd2f into main Jan 16, 2025
8 checks passed
@moabu moabu deleted the feat-jans-cedarling-sidecar branch January 16, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants