-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-cedarling): Implement check authorization principals based on the schema for action #10126
Conversation
Signed-off-by: Oleh Bohzok <[email protected]>
…aling-issue-10072 Signed-off-by: Oleh Bohzok <[email protected]>
…ties to file `entity_types.rs` Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
…ble and to be `authorize_info` optional for each principal Signed-off-by: Oleh Bohzok <[email protected]>
…aling-issue-10072 Signed-off-by: Oleh Bohzok <[email protected]>
… `role_authorize_info` now is vector It allows to log many role authorize info results Signed-off-by: Oleh Bohzok <[email protected]>
…`s in `schema` for `action` Signed-off-by: Oleh Bohzok <[email protected]>
… different folders Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
…applied to action Signed-off-by: Oleh Bohzok <[email protected]>
…principal only when it can be applied to action Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
…rom `Jans` works correctly Signed-off-by: Oleh Bohzok <[email protected]>
DryRun Security SummaryThe pull request covers various improvements to the Cedarling application's authorization functionality, focusing on enhancing security, robustness, and comprehensive test coverage. Expand for full summarySummary: The code changes in this pull request cover various aspects of the Cedarling application, with a focus on improving the security and robustness of the authorization functionality. The changes include updates to the Key security-related improvements include:
Overall, the changes demonstrate a strong focus on security and reliability, with a particular emphasis on ensuring that the authorization system can handle a wide range of inputs and edge cases without introducing vulnerabilities or compromising the application's security posture. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Signed-off-by: Oleh Bohzok <[email protected]>
Signed-off-by: Oleh Bohzok <[email protected]>
…aling-issue-10072 Signed-off-by: Oleh Bohzok <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python changes look good. Is example_files/policy-store.json
update in PR #10098 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Prepare
Description
Target issue
issue
closes #10072
Implementation Details
principals
:User
,Role
,Workload
based on schemacedar-policy schema. But after realized that it is OK to handle error from
cedar-policy`Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.