Follow-up bug fix in freetype when using external libz; add conflict for node-js@21: with [email protected] #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
bugfix/freetype_zlibapi_depbuildenv
branch
from
ce828eb to
1bfb0a5
Compare
…t build environments
…tin/packages/node-js/package.py var/spack/repos/builtin/packages/node-js/wasm-compiler-gcc11p2.patch) Since this bug fix is not sufficient, add a conflict for node-js@21: with [email protected]
climbfuji
force-pushed
the
bugfix/freetype_zlibapi_depbuildenv
branch
from
1bfb0a5 to
53c39ca
Compare
9 tasks
srherbener
approved these changes
Jan 10, 2025
|
Thanks @srherbener! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two separate changes/commits:
freetypewhen using an externallibz. We also need to add the location of the externalzlib.pctoPKG_CONFIG_PATHto the dependents offreetype.node-js@21:with one particular version ofgcc, namely[email protected]. As noted in FTBFS, version 22.11, gcc 11.2 nodejs/node#55596,[email protected]seems to have a bug that prevents building newernode-jsversions. See Installation issue: node-js@22 with [email protected] spack/spack#48492 for more information.This PR is required for JCSDA/spack-stack#1410 and it was tested as part of it on three HPC systems used by the Navy (Atlantis, Narwhal, Nautilus).