Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io-classes-1.7 #4951

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

io-classes-1.7 #4951

wants to merge 6 commits into from

Conversation

coot
Copy link
Contributor

@coot coot commented Sep 6, 2024 •
edited
Loading

  • forAllProjectPackages needs to be fixed
  • infinite recusion error: 
    error:
     … while calling the 'derivationStrict' builtin

       at /builtin/derivation.nix:9:12: (source not available)

     … while evaluating derivation 'required'
       whose name attribute is located at /nix/store/y8pbnccb8bc1p8fchx7zkb0874yblrg3-source/pkgs/stdenv/generic/make-derivation.nix:336:7

     … while evaluating attribute 'constituents' of derivation 'required'

       at /nix/store/y8pbnccb8bc1p8fchx7zkb0874yblrg3-source/pkgs/build-support/release/default.nix:69:16:

         68|     pkgs.runCommand name
         69|       { inherit constituents meta;
           |                ^
         70|         preferLocalBuild = true;

     (stack trace truncated; use '--show-trace' to show the full trace)

     error: infinite recursion encountered

     at /nix/store/qgcnijjpgkdp0w9ld0iyxv76jk2wp0xx-source/modules/install-plan/redirect.nix:39:11:

         38|         // lib.optionalAttrs (componentsByName ? lib) {
         39|           library = lookupComponent "" "" componentsByName.lib;
           |           ^
         40|         };

@coot coot force-pushed the coot/io-classes-1.7 branch from ffe52e1 to 5abdefc Compare December 9, 2024 22:15
@jorisdral
Copy link
Contributor

Is there anything in particular that is holding this PR back from being merged? I'd like to use a library in ouroboros-consensus that depends on io-classes-1.7, but it means that ouroboros-network and typed-protocols have to be updated

@coot
WIP: DO NOT MERGE
63da2af 
We need to fix `forAllProjectsPackages`:
```
nix build .\#hydraJobs.x86_64-linux.required -j12
trace: evaluation warning: Explicitly set the ABI version of 'webkitgtk'
error:
       … while calling the 'head' builtin

         at /nix/store/y8pbnccb8bc1p8fchx7zkb0874yblrg3-source/lib/attrsets.nix:1575:11:

         1574|         || pred here (elemAt values 1) (head values) then
         1575|           head values
             |           ^
         1576|         else

       … in the left operand of the update (//) operator

         at /nix/store/qgcnijjpgkdp0w9ld0iyxv76jk2wp0xx-source/lib/default.nix:404:29:

          403|         else
          404|           (b.${name} or {}) // (a.${name} or {});
             |                             ^
          405|     }) (__attrNames (a // b)));

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'package' missing

       at /nix/store/js4czlgq317dwr4zf1qr75xmk2pq6svr-source/nix/ouroboros-network.nix:27:27:

           26|       type = lib.types.attrsOf (lib.types.submodule ({ config, ... }: {
           27|         config = lib.mkIf config.package.isProject (cfg args);
             |                           ^
           28|       }));
 ```
@coot coot force-pushed the coot/io-classes-1.7 branch from 5abdefc to 63da2af Compare December 12, 2024 07:33
@coot
Copy link
Contributor Author

coot commented Dec 12, 2024

@jorisdral I updated PR description.

@coot coot added nix This includes CI, nix changes or cabal dependencies io-classes Issues / PRs related to io-classes labels Dec 12, 2024
@coot coot marked this pull request as ready for review December 12, 2024 08:20
@coot coot requested review from a team as code owners December 12, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
io-classes Issues / PRs related to io-classes nix This includes CI, nix changes or cabal dependencies
Projects
Ouroboros Network
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coot @jorisdral @hamishmack