TxSubmission, part 1: code refactoring #4914
Merged
+293
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Quiet to derive the Show instance.
Deprecated TxSizeInBytes.
Use `chooseEnum` to guarantee that the maximal tx size has a small upper bound. Note: this came up when using `SizeInBytes` semigroup instance and encountering an overflow. We never should have more than 4GB inflight txs, so it's fine for now.
* `-c` only check committed files in HEAD * `-u` only check uncommitted files * `-h` show help message Without any flag; check all files.
coot
force-pushed
the
coot/tx-submission-refactoring
branch
from
1fe9d57 to
e4a28e9
Compare
coot
force-pushed
the
coot/tx-submission-refactoring
branch
from
719b3a1 to
e4a28e9
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is preparation work for #3311. It includes code refactoring, fixes some warnings, and adds newtype wrappers.
^>=0.2Checklist
Quality
Maintenance
ouroboros-networkproject.