Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command argument types for genesis commands #398

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Oct 23, 2023

Changelog

- description: |
    Refactor command argument types for the `genesis` commands.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR is similar to #360 and #371 and #395. It adds or removes no functionality, and only refactors some types. I'm doing this as a preparation for an upcoming PR that will rework the genesis create-staked command.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The code is definitely easier to maintain after this change.

@carlhammann carlhammann enabled auto-merge October 23, 2023 11:28
@carlhammann carlhammann force-pushed the ch/genesis-command-arg-types branch from 400fec6 to f62ad62 Compare October 23, 2023 11:31
@carlhammann carlhammann added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 23, 2023
@carlhammann carlhammann added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 23, 2023
@carbolymer carbolymer added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit ee7582f Oct 24, 2023
19 checks passed
@carbolymer carbolymer deleted the ch/genesis-command-arg-types branch October 24, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants