-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stake-address-info
query also return deposit
#375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the improvement but can you inform QA about this change. They may depend on the output.
& onLeft (left . QueryCmdLocalStateQueryError . EraMismatchError) | ||
|
||
return $ do | ||
writeStakeAddressInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth updating the function name to say writeStakeAddressInfoAndBalances
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure; the name you propose wouldn't even have been completely descriptive before this change, but now we write balances, stake pools, and deposits... In short, all information associated with a stake address that we can query.
Nothing -> liftIO $ LBS.putStrLn (encodePretty jsonInfo) | ||
Just (File fpath) -> | ||
handleIOExceptT (QueryCmdWriteFileError . FileIOError fpath) | ||
$ LBS.writeFile fpath (encodePretty jsonInfo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use this function here? https://github.com/input-output-hk/cardano-api/blob/newhoggy/new-shelleyToAlonzoEraToShelleyToBabbageEra-function/cardano-api/internal/Cardano/Api/IO.hs/#L115-L123
6ae33ec
to
5b63e07
Compare
Changelog
Context
This PR closes #353.
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7