Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drep id: support key hash #1009

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 8, 2025

Changelog

- description: |
    drep id: support key hash as input
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

While we're still unsure whether we should use https://cips.cardano.org/cip/CIP-0105 or https://cips.cardano.org/cip/CIP-129, we know we have to extend drep id to support key hashes and scripts. This PR makes a small forward and implements the former.

Part of fixing #883

How to trust this PR

Observe that we honor the behavior tagged as deprecated in CIP-105 (our existing already follows this behavior flagged "deprecated", so we are being consistent here):

image

  • The existing golden tests for drep id still pass: we didn't change the default behavior

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Jan 8, 2025

cc @CarlosLopezDeLara because this is the improvement we found out together during our pair programming session of yesterday

@smelc smelc added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 5c76870 Jan 8, 2025
73 of 78 checks passed
@smelc smelc deleted the smelc/drep-id-extension-to-key-hashes branch January 8, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants