Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
While we're still unsure whether we should use https://cips.cardano.org/cip/CIP-0105 or https://cips.cardano.org/cip/CIP-129, we know we have to extend
drep id
to support key hashes and scripts. This PR makes a small forward and implements the former.Part of fixing #883
How to trust this PR
Observe that we honor the behavior tagged as deprecated in CIP-105 (our existing already follows this behavior flagged "deprecated", so we are being consistent here):
drep id
still pass: we didn't change the default behaviorChecklist