Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore aarch64 support #679

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Restore aarch64 support #679

merged 1 commit into from
Nov 12, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Nov 12, 2024

Changelog

- description: |
    Restored `aarch64` support
  type:
  - maintenance

Context

cardano-cli already has support aarch64 and it depends on cardano-api, so I am not sure why this is disabled.

How to trust this PR

If the CI passes I would trust it.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Nov 12, 2024
@palas palas requested a review from a team as a code owner November 12, 2024 12:34
smelc
smelc approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed these platforms have been running smoothly on CLI since a while, so approving 👍

@palas palas enabled auto-merge November 12, 2024 12:45
@palas palas added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit d7c62a0 Nov 12, 2024
27 of 29 checks passed
@palas palas deleted the restore-aarch64-support branch November 12, 2024 13:12
@carbolymer
Copy link
Contributor

@smelc smooth as butter 😆
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

Assignees

@palas palas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palas @carbolymer @smelc