Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Fourmolu as formatter #582

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Set Fourmolu as formatter #582

merged 1 commit into from
Jul 6, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 5, 2024

Changelog

- description: |
    Added Fourmolu to dev shell, to haskell-style-lint hook script, and modified stylish-haskell action to use Fourmolu instead
  type:
  - maintenance    # not directly related to the code

Context

We don't want to have to worry about formatting .hs files, and we want to be consistent. This PR tries to address this by establishing and enforcing a strong formatter (Formoulu).

How to trust this PR

Probably check that the hook works for you. Also that you are happy with the changes and configuration, and that the CI passes.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas force-pushed the set-fourmolu-as-formatter branch 4 times, most recently from 359b85c to cd2d854 Compare July 5, 2024 01:35
@palas palas self-assigned this Jul 5, 2024
@palas palas added the test Adding or reworking tests label Jul 5, 2024
@palas palas force-pushed the set-fourmolu-as-formatter branch from cd2d854 to b76f949 Compare July 6, 2024 01:33
@palas palas enabled auto-merge July 6, 2024 01:40
@palas palas added this pull request to the merge queue Jul 6, 2024
Merged via the queue into main with commit 19da63d Jul 6, 2024
24 checks passed
@palas palas deleted the set-fourmolu-as-formatter branch July 6, 2024 02:39
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Pablo! I have a few suggestions for fourmolu settings we could use.

fourmolu.yaml Show resolved Hide resolved
fourmolu.yaml Show resolved Hide resolved
fourmolu.yaml Show resolved Hide resolved
fourmolu.yaml Show resolved Hide resolved
fourmolu.yaml Show resolved Hide resolved
fourmolu.yaml Show resolved Hide resolved
@palas palas mentioned this pull request Jul 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding or reworking tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants