[Any Drill][Fixed] Do not overwrite other drill pairs with pth_id #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the overwriting of non through-hole drill pair files when
pth_id
is specified.I've also modifed the YAML files for the test cases (non-legacy) so that the default
pth_id
andnpth_id
are explicitly specified. Without the fix, it will overwrite the files which results in the test failing.I'm not sure how to modify the legacy YAML files for this test, I've tried to add
pth_id
andnpth_id
but doesn't seem to change anything, I assume the legacy way of generating drill files did not have a function to rename the files? In this case it would be a non-issue