-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Any Drill][Fixed] Do not overwrite other drill pair files #757
Conversation
Ok, can you provide examples for the fixes? |
Running this config on the
Now when using this config, it results in these two files:
|
Also, in general where should I put the test cases? Do I just create a YAML file in |
Yes, test configs goes there.
Usually a PCB/SCH is enough, but yes test cases goes there.
It depends on the test, a test must be added to the test script related to it. In this case |
I found the source of the "None" issue, is a general issue and shouldn't be fixed in the drill code. |
Avoid interpreting them as the "None" string, now they are just None See #757
The above patch fixes the "None" issue, note that now you get an error, the same you get by leaving empty the |
Ok, should I open two separate PRs? One for the overwriting and one for the other drill pairs ID. |
Yes.
The Makefile handles it. Lets say you want to run the
For KiCad 7 you just use |
When running the command, I always get an assertion error:
|
The |
This PR does the following:
pth_id
is in the yaml file but left empty. Previously it was interpreted as aNone
string