Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to migrate fieldreport number #2349

Merged

Conversation

sudip-khanal
Copy link

Addresses

Migration of Field Report Data for Dynamic Title Suffixes

Changes

  • Add logic to migrate field report number from the old summary

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes,
let's change the file name to migrate_field_report_number

api/management/commands/field-report-fix-suffixes.py Outdated Show resolved Hide resolved
api/management/commands/field-report-fix-suffixes.py Outdated Show resolved Hide resolved
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes

api/management/commands/migrate_field_report_number.py Outdated Show resolved Hide resolved
api/management/commands/migrate_field_report_number.py Outdated Show resolved Hide resolved
api/management/commands/migrate_field_report_number.py Outdated Show resolved Hide resolved
api/management/commands/migrate_field_report_number.py Outdated Show resolved Hide resolved
@samshara samshara requested review from susilnem and thenav56 January 3, 2025 07:02
@susilnem susilnem force-pushed the migration/field-report-suffixes branch 4 times, most recently from de147de to eb44868 Compare January 6, 2025 10:57
@susilnem susilnem force-pushed the project/field-report-translations branch 3 times, most recently from 5a7fa1b to c8f0816 Compare January 7, 2025 10:20
@thenav56 thenav56 force-pushed the migration/field-report-suffixes branch from eb44868 to 50e3ef5 Compare January 7, 2025 11:25
@susilnem susilnem marked this pull request as ready for review January 8, 2025 04:07
@susilnem susilnem merged commit 2bc3447 into project/field-report-translations Jan 15, 2025
3 checks passed
@susilnem susilnem deleted the migration/field-report-suffixes branch January 15, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants