Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bnfc: drop workaround, update build/test #204348

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jan 15, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Aeson got a metadata revision today so will will be dropping workarounds.

Also flatten some build steps

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Jan 15, 2025
@github-actions github-actions bot added haskell Haskell use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue labels Jan 15, 2025
@cho-m cho-m force-pushed the bnfc-drop-workaround branch from c48e56d to cca4323 Compare January 15, 2025 14:44
@chenrui333 chenrui333 force-pushed the bnfc-drop-workaround branch from cca4323 to 5269cd4 Compare January 15, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles haskell Haskell use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant