Fix fetch for Intel Sequoia

[muneebmahmed]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Fixes #19060. On Intel Sequoia, brew install install from Sonoma bottles as expected, but brew fetch gives errors due to lack of a sequoia: bottle. I'm not sure how exactly the formula installer resolves the bottle tag, but I just took a look at the function that's called and copied it over to the fetch command, and it worked:

brew/Library/Homebrew/formula_installer.rb

Line 218 in 1e91082

bottle = formula.bottle_for_tag(Utils::Bottles.tag)

[apainintheneck]

Thanks for taking a look at this. I don't think the current solution of using Utils::Bottles.tag will work here since it relies on HOMEBREW_PROCESSOR and HOMEBREW_SYSTEM which are both set once at start up time. This means that you'd only be able to use this to download bottles for your current system and arch and not for the system and arch specified by the user which is an existing feature.

It sounds like ideally we'd have some way to realize that an intel-sequoia bottle doesn't exist and that the sonoma bottle would be used instead. Then, maybe we could display that as a warning to the user.

[MikeMcQuaid]

It sounds like ideally we'd have some way to realize that an intel-sequoia bottle doesn't exist and that the sonoma bottle would be used instead.

Agreed. The logic in find_matching_tag is the relevant ones here; looking at those call-sites should help narrow this down. If you're lost: shout and I'll help more!

Then, maybe we could display that as a warning to the user.

No need to warn for this given we don't warn for brew install either.

[cho-m]

One thing is that fallback would occur if arch were aligned since BottleSpecification#tag? and other methods default to no_older_versions=false

Currently, brew fetch uses :arm and :intel as input and passes these on as arguments. Bottle tag use :arm64 and :x86_64 so some parts of code consider these different architectures, e.g.

brew(main):001> Formula["qt"].bottled?(Utils::Bottles::Tag.new(system: :sequoia, arch: :arm))
=> false
brew(main):002> Formula["qt"].bottled?(Utils::Bottles::Tag.new(system: :sequoia, arch: :arm64))
=> true
brew(main):003> Formula["qt"].bottle_for_tag(Utils::Bottles::Tag.new(system: :sequoia, arch: :arm64)).tag
=> #<Utils::Bottles::Tag:0x000000012a8db8c0 @arch=:arm64, @system=:sonoma, @to_macos_version=#<MacOSVersion: "14">>

brew/Library/Homebrew/extend/os/mac/utils/bottles.rb

Lines 49 to 52 in 4c9de7d

	tags.find do |candidate|
	next if candidate.arch != tag.arch
	candidate.to_macos_version <= tag_version