-
Notifications
You must be signed in to change notification settings - Fork 57
Add appliance network information #399
base: master
Are you sure you want to change the base?
Conversation
method for getting appliance network information
tidy, remove stray return line
add appliance network information class link
add appliance_network_information attribute
…nd invalid escape sequence (W605). One instance of W605 in hpOneView/resources/networking/ethernet_networks.py:175:32
I have been able to get tox to complete successfully by adding a couple of ignores to Most of the warnings were W504 (line break after binary operator) and one was an invalid escape sequence (W605) |
GET https://{appl}/rest/appliance/network-interfaces
@chrisarnott86 - Thanks for your contributions. I have re-triggered the travis build and it's able to succeed now. May be there was some issue with the travis CI tool. Can you revert back your changes for tox.ini and check now. |
I've reverted tox.ini back to the original in my local copy, and I'm getting failed checks again. Here's the output:
Presumably the travis buld is currently only working because of my changed |
@chrisarnott86 - ok. May be I was wrong in understanding how Travis builds the code. I thought it takes that point of committed code. You ca ignore my comment. |
Given that the travis checks are failing in relation to files unrelated to my pull request, it shouldn't hinder checking of my commits. Does anyone else find that the tox checks fail on a fresh checkout of master? |
Any updates here? |
Description
This is my first ever contribution to a project on Github so please tread lightly...
A new module is added which enables collection of Appliance Network Interfaces information (api call
GET https://{appl}/rest/appliance/network-interfaces)
Testing has been done via my own script, I haven't been able to get tox to complete, I don't think the errors I'm getting are related to the changes I've made, something to do with the general setup. Any advice on using tox is appreciated. (it's failing with an invocation error on flake8 after output shows examples/scmb/scmb.py:51:17: W504 line break after binary operator)
Check List
$ tox
).