This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Fix bug in index_resources.get_all() #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamonnotoole
force-pushed
the
fix-index
branch
2 times, most recently
from
a407e90 to
c3493c3
Compare
|
Coverage decreased because I've removed a few lines from index_resources.py |
The essential problem is that index_resources.get_all() calls the Resource get() method which doesn't handle pagination and thus only returns the first page of results. The complication is that index_resources.get_all() builds its own URI complete with filtering. Thus we call index_resources.get_all() with 'start', 'count' and 'uri' arguments and remove the 'start' and 'count' fields from the pre-built uri. The implicated index_resource unit-tests have been updated. Fixes HewlettPackard#364
dileepds
approved these changes
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The essential problem is that index_resources.get_all() calls the
Resource get() method which doesn't handle pagination and thus only
returns the first page of results. The complication is that
index_resources.get_all() builds its own URI complete with filtering, so
the Resource get_all() is probably not appropriate since it builds the
complete URI from a set of provided filters. To fix we've added a new
method to Resource - get_all_prebuilt_uri - which passes the pre-built
URI directly to the underlying __do_requests_to_getall method. The
implicated unit-tests have been updated.
Issues Resolved
[Fixes #364]
Check List
$ tox).