Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Extending socket options test to group options. #3086

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Dec 12, 2024

Unit tests are failing due to bugs in setting/getting socket group options. See #3074.

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [tests] Area: Unit tests labels Dec 12, 2024
@maxsharabayko maxsharabayko added this to the v1.5.5 milestone Dec 12, 2024
@@ -33,6 +33,7 @@

# Ignore any folder starting from underscore
_*/
venv/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to be removed. Slipped through.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
venv/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants