Skip to content

Commit

Permalink
Remove isProApplicant from registration schemas
Browse files Browse the repository at this point in the history
  • Loading branch information
Timothy-Gonzalez committed Jan 12, 2025
1 parent 3780bf1 commit 5df5418
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion src/services/admission/admission-router.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const OTHER_DECISION = {
} satisfies AdmissionDecision;

const TESTER_APPLICATION = {
isProApplicant: false,
userId: TESTER.id,
preferredName: TESTER.name,
legalName: TESTER.name,
Expand Down
1 change: 0 additions & 1 deletion src/services/profile/profile-router.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ const PROFILE = {
const REGISTRATION = {
userId: TESTER.id,
hasSubmitted: true,
isProApplicant: false,
preferredName: TESTER.name,
legalName: TESTER.name,
emailAddress: TESTER.email,
Expand Down
1 change: 0 additions & 1 deletion src/services/registration/registration-router.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import type { AxiosResponse } from "axios";
import { MailInfo } from "../mail/mail-schemas";

const APPLICATION = {
isProApplicant: false,
preferredName: TESTER.name,
legalName: TESTER.name,
emailAddress: TESTER.email,
Expand Down
5 changes: 0 additions & 5 deletions src/services/registration/registration-schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ export class RegistrationApplication {
@prop({ default: false })
public hasSubmitted: boolean;

@prop({ required: true })
public isProApplicant: boolean;

@prop({ required: true })
public preferredName: string;

Expand Down Expand Up @@ -187,7 +184,6 @@ export const RegistrationStatusSchema = z

export const RegistrationApplicationRequestSchema = z
.object({
isProApplicant: z.boolean(),
preferredName: z.string(),
legalName: z.string(),
// Email address needs to allow empty string as placeholder value. Ideally we change this in the future, but this is a temp fix.
Expand Down Expand Up @@ -226,7 +222,6 @@ export const RegistrationApplicationRequestSchema = z
degree: Degree.ASSOCIATES,
major: "Computer Science",
gradYear: 0,
isProApplicant: true,
proEssay: "I wanna be a Knight",
considerForGeneral: true,
requestedTravelReimbursement: false,
Expand Down
1 change: 0 additions & 1 deletion src/services/staff/staff-router.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ const TESTER_REGISTRATION = {
hackOutreach: [HackOutreach.INSTAGRAM],
dietaryRestrictions: ["Vegan", "No Pork"],
resumeFileName: "GitHub cheatsheet.pdf",
isProApplicant: false,
legalName: "Ronakin Kanandani",
considerForGeneral: false,
requestedTravelReimbursement: true,
Expand Down

0 comments on commit 5df5418

Please sign in to comment.