add email validation to registration schema

HackIllinois · Jan 4, 2025 · 5543802 · 5543802
1 parent 8b4e5a3
commit 5543802
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/services/registration/registration-router.test.ts b/src/services/registration/registration-router.test.ts
@@ -37,6 +37,10 @@ const APPLICATION = {
     hackOutreach: [HackOutreach.INSTAGRAM],
 } satisfies RegistrationApplicationRequest;
 
+const APPLICATION_INVALID_EMAIL = Object.assign({}, APPLICATION, {
+    emailAddress: "invalidemail",
+});
+
 const UNSUBMITTED_REGISTRATION = { userId: TESTER.id, hasSubmitted: false, ...APPLICATION } satisfies RegistrationApplication;
 const UNSUBMITTED_OTHER_REGISTRATION = {
     ...UNSUBMITTED_REGISTRATION,
@@ -118,6 +122,13 @@ describe("POST /registration/", () => {
         expect(JSON.parse(response.text)).toHaveProperty("error", "BadRequest");
     });
 
+    it("should provide bad request error when email is invalid", async () => {
+        const response = await postAsUser("/registration/")
+            .send(APPLICATION_INVALID_EMAIL)
+            .expect(StatusCode.ClientErrorBadRequest);
+        expect(JSON.parse(response.text)).toHaveProperty("error", "BadRequest");
+    });
+
     it("should provide already submitted error when user has already submitted registration", async () => {
         await Models.RegistrationApplication.create(SUBMITTED_REGISTRATION);
 

diff --git a/src/services/registration/registration-schemas.ts b/src/services/registration/registration-schemas.ts
@@ -190,7 +190,7 @@ export const RegistrationApplicationRequestSchema = z
         isProApplicant: z.boolean(),
         preferredName: z.string(),
         legalName: z.string(),
-        emailAddress: z.string(),
+        emailAddress: z.string().email({ message: "Invalid email syntax." }),
         gender: GenderSchema,
         race: z.array(RaceSchema),
         resumeFileName: z.string().optional(),