Amanda/ui features #30

ahinchman1 · 2017-03-12T17:15:30Z

Added KDIC image. Closes #29

alexthemitchell

We'll get you higher resolution images today at the meeting, so I'm going to withhold approval for now until these changes are made.

alexthemitchell · 2017-03-12T17:43:35Z

KDIC/PlayerViewController.swift

@@ -7,16 +7,22 @@ class PlayerViewController: UIViewController {
  @IBOutlet weak var subtitleLabel: UILabel!
  @IBOutlet weak var imageView: UIImageView!

+    @IBOutlet weak var KDICPhoto: UIImageView!


I think this is the same as imageView.

alexthemitchell · 2017-03-12T17:43:56Z

KDIC/PlayerViewController.swift

  override func viewDidAppear(_ animated: Bool) {
    super.viewDidAppear(animated)
    print("About to play")
    KDICPlayer.play()
    print("Playing!")
  }
+
+


Nit: Extraneous newline

Please fix.

alexthemitchell · 2017-03-12T17:45:51Z

KDICCore/KDICPlayer.swift

@@ -20,6 +20,7 @@ open class KDICPlayer {
    player.pause()
  }

+    /** to fix **/


We've made a ticket, so you can remove this comment.

Alternatively, if you'd like to keep it, we should use proper Swift documentation syntax. You can find information on that here. (Hint: There is a tag called Bug.)

If you choose to do the documentation, make sure you reference the github issue number in the comment (#29).

alexthemitchell · 2017-03-12T17:49:13Z

Also, make sure that you submit pull requests which merge into the pheonix branch. This one originally was trying to merge into master.

alexthemitchell

Please also remove the Screen Shot file from the repository (git rm --cached KDIC/Base.lproj/Screen\ Shot\ 2017-03-08\ at\ 5.54.02\ PM.png). Otherwise this looks really great!

alexthemitchell · 2017-03-12T21:18:17Z

KDIC/PlayerViewController.swift

  override func viewDidAppear(_ animated: Bool) {
    super.viewDidAppear(animated)
    print("About to play")
    KDICPlayer.play()
    print("Playing!")
  }
+
+


Please fix.

alexthemitchell · 2017-03-12T21:18:31Z

KDICCore/KDICPlayer.swift

 open class KDICPlayer {
  private static var player: AVPlayer = {
    let asset = AVURLAsset(url: streamURL)
    let playerItem = AVPlayerItem(asset: asset)
+    // 


Please remove

alexthemitchell · 2017-03-12T21:18:45Z

KDICCore/KDICPlayer.swift

  }

+    /** to fix **/


Please remove.

alexthemitchell · 2017-03-12T21:19:00Z

KDICCore/KDICPlayer.swift

  open class func toggle() {
-    if isPlaying {
+    if isPlaying == true {


Must we use == here? Can't we just do if isPlaying?

alexthemitchell · 2017-03-12T21:19:33Z

KDICCore/KDICPlayer.swift

@@ -3,29 +3,40 @@ import AVFoundation

 private let streamURL = URL(string: "http://kdic.grinnell.edu/stream")!

+let kdicInstance = KDICPlayer();
+
+private var isPlaying = false;


Try private(set) var isPlaying = false This will resolve my comment below.

alexthemitchell · 2017-03-12T21:20:20Z

KDICCore/KDICPlayer.swift

      pause()
    } else {
      play()
    }
  }
+
+    open func currentlyPlaying() -> Bool {


Use a semi-public property above to make a private setter with a public getter. I put some code above. Please then remove this function.

done(?) Please check this one real quick

alexthemitchell · 2017-03-12T21:21:08Z

KDICCore/KDICPlayer.swift

@@ -3,29 +3,40 @@ import AVFoundation

 private let streamURL = URL(string: "http://kdic.grinnell.edu/stream")!

+let kdicInstance = KDICPlayer();


Can we just call this variable player?

Actually, do you ever use this variable? I don't think we need it.

done, you're right I don't even use it lol

alexthemitchell

Please also use the git command I posted earlier to remove the screenshot.

alexthemitchell · 2017-03-13T18:17:29Z

KDICCore/KDICPlayer.swift

  }

  open class func toggle() {
-    if isPlaying {
+    if isPlaying == true {


Do we need to have == true here? Please remove if it compiles without it. isPlaying is a Bool.

alexthemitchell · 2017-03-13T18:17:55Z

KDICCore/KDICPlayer.swift

 open class KDICPlayer {
  private static var player: AVPlayer = {
    let asset = AVURLAsset(url: streamURL)
    let playerItem = AVPlayerItem(asset: asset)
+    let currentlyPlaying = isPlaying;


You never use this binding.

alexthemitchell · 2017-03-13T18:18:47Z

KDICCore/KDICPlayer.swift

@@ -3,25 +3,28 @@ import AVFoundation

 private let streamURL = URL(string: "http://kdic.grinnell.edu/stream")!

+private(set) var isPlaying = false;


This should be in the class, like on line 9.

alexthemitchell · 2017-03-13T18:19:24Z

KDIC/PlayerViewController.swift

  override func viewDidAppear(_ animated: Bool) {
    super.viewDidAppear(animated)
    print("About to play")
    KDICPlayer.play()
    print("Playing!")
  }
+


Nit: Extraneous newline.

RoyHarvey · 2017-03-16T10:56:09Z

Hi -- just pulled latest and hit this issue... Please ignore if this is known and/or already in progress:

"Type ANY has no subscript members..."

File: FeedViewController.swift

func loadTableData(_ day: String){
    let scheduleDictionary = self.kdicScrapperReqs!.jsonDictionary!["data"]![day]! as! NSDictionary as Dictionary
    
    self.dayScheduleKeysArray = Array(scheduleDictionary.keys)
    self.dayScheduleValuesArray = Array(scheduleDictionary.values)
    
    scheduleDataLoadingIndicator.stopAnimating()
    scheduleDataLoadingIndicator.isHidden = true
    
    self.scheduleTableView.reloadData()
}

===

Thanks

alexthemitchell

KDIC/Base.lproj/Screen Shot 2017-03-08 at 5.54.02 PM.png still needs to be removed

alexthemitchell · 2017-04-09T21:10:58Z

KDIC/PlayerViewController.swift

+
+    self.imageView.image = UIImage(named: "Equalizer")
+
+    button.setImage(imgShell1, forState:.Normal);


Does this work? Where is imgShell1 coming from? Same for coin in the next line.

alexthemitchell · 2017-04-09T21:11:40Z

KDIC/PlayerViewController.swift

  override func viewDidAppear(_ animated: Bool) {
    super.viewDidAppear(animated)
    print("About to play")
    KDICPlayer.play()
    print("Playing!")
  }
+
+    func resizeImageWithAspect(image: UIImage,size: CGSize)->UIImage


I don't think you need this. You can use the Aspect Fill setting I showed you on the storyboard to adjust how the image appears in the UIImage view.

Laelson · 2017-05-08T19:41:32Z

How to solve this?
"Type ANY has no subscript members..."

File: FeedViewController.swift

thanks,

func loadTableData(_ day: String){
let scheduleDictionary = self.kdicScrapperReqs!.jsonDictionary!["data"]![day]! as! NSDictionary as Dictionary

self.dayScheduleKeysArray = Array(scheduleDictionary.keys)
self.dayScheduleValuesArray = Array(scheduleDictionary.values)

scheduleDataLoadingIndicator.stopAnimating()
scheduleDataLoadingIndicator.isHidden = true

self.scheduleTableView.reloadData()

}

added KDIC image

925f3b8

alexthemitchell changed the base branch from master to pheonix March 12, 2017 17:43

alexthemitchell requested changes Mar 12, 2017

View reviewed changes

ahinchman1 added 2 commits March 12, 2017 13:45

replaced KDIC with ImageView

9558056

Fixed toggle issue

07287bd

alexthemitchell requested changes Mar 12, 2017

View reviewed changes

fixed constraints, refactored out StackView

211aa44

ahinchman1 self-assigned this Mar 13, 2017

ahinchman1 added 2 commits March 12, 2017 21:29

syntax fixes (See comments from merge #30)

559eea6

Fixed merge #30 issues

58e0dae

alexthemitchell requested changes Mar 13, 2017

View reviewed changes

added image data sets

92ce5b3

alexthemitchell mentioned this pull request Apr 9, 2017

Amanda/ui features #32

Closed

alexthemitchell requested changes Apr 9, 2017

View reviewed changes

ahinchman1 added 2 commits April 10, 2017 17:21

Add "live" functionality, rename "play" to "unpause"

b7c5931

Fix errors and update storyboard

8741444

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amanda/ui features #30

Amanda/ui features #30

ahinchman1 commented Mar 12, 2017 •

edited by alexthemitchell

Loading

alexthemitchell left a comment

alexthemitchell Mar 12, 2017

alexthemitchell Mar 12, 2017

alexthemitchell Mar 12, 2017

ahinchman1 Mar 13, 2017

alexthemitchell Mar 12, 2017

alexthemitchell Mar 12, 2017

alexthemitchell commented Mar 12, 2017

alexthemitchell left a comment

alexthemitchell Mar 12, 2017

alexthemitchell Mar 12, 2017

ahinchman1 Mar 13, 2017

alexthemitchell Mar 12, 2017

ahinchman1 Mar 13, 2017

alexthemitchell Mar 12, 2017

alexthemitchell Mar 12, 2017

ahinchman1 Mar 13, 2017

alexthemitchell Mar 12, 2017

ahinchman1 Mar 13, 2017

alexthemitchell Mar 12, 2017

alexthemitchell Mar 12, 2017

ahinchman1 Mar 13, 2017

alexthemitchell left a comment

alexthemitchell Mar 13, 2017

alexthemitchell Mar 13, 2017

alexthemitchell Mar 13, 2017

alexthemitchell Mar 13, 2017

RoyHarvey commented Mar 16, 2017

alexthemitchell left a comment

alexthemitchell Apr 9, 2017

alexthemitchell Apr 9, 2017

Laelson commented May 8, 2017

		@@ -3,29 +3,40 @@ import AVFoundation

		private let streamURL = URL(string: "http://kdic.grinnell.edu/stream")!

		let kdicInstance = KDICPlayer();

		@@ -3,25 +3,28 @@ import AVFoundation

		private let streamURL = URL(string: "http://kdic.grinnell.edu/stream")!

		private(set) var isPlaying = false;


		self.imageView.image = UIImage(named: "Equalizer")

		button.setImage(imgShell1, forState:.Normal);

Amanda/ui features #30

Are you sure you want to change the base?

Amanda/ui features #30

Conversation

ahinchman1 commented Mar 12, 2017 • edited by alexthemitchell Loading

alexthemitchell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexthemitchell commented Mar 12, 2017

alexthemitchell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexthemitchell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RoyHarvey commented Mar 16, 2017

File: FeedViewController.swift

alexthemitchell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Laelson commented May 8, 2017

ahinchman1 commented Mar 12, 2017 •

edited by alexthemitchell

Loading