Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Embed web stories on landing page cards #908

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jan 8, 2025

Description

This PR aims to embed web-stories in the cards of each of the landing pages.

Relevant Technical Choices

  • Clicking on the web stories icon in the landing page will open a web story in a player format.

Testing Instructions

  • Clone this branch
  • In the terminal run npm i && npm run build:ext.
  • In the browser, go to example.com.
  • Now open PSAT in DevTools.
  • Now in PSAT open any landing page which has cards.
  • There should be a web story icon, click on it, and it will open a story in story player format.

Additional Information:

Screenshot/Screencast

ws.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #909

@amovar18 amovar18 self-assigned this Jan 8, 2025
@amovar18 amovar18 added this to the v0.13.0 milestone Jan 8, 2025
@amovar18 amovar18 marked this pull request as ready for review January 8, 2025 10:26
@amovar18 amovar18 requested review from mohdsayed and mayan-000 and removed request for mohdsayed January 8, 2025 10:33
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mohdsayed mohdsayed merged commit 48f35be into release/v0.13.0 Jan 9, 2025
6 checks passed
@mohdsayed mohdsayed deleted the feat/web-stories-tabs branch January 9, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants